Optimize private zone discovery#93
Conversation
Optimize the private zone discovery algorithm to replace the O(n) AWS API calls with a single O(1) call to find the zone by its tag.
openshift-ci-robot
added
size/XXL
|
Previously, once per startup, the controller would call |
|
openshift/origin#21617 passes against this |
|
Structure looks fine to me. |
|
The hosted zone region lookup thing is a bit wierd |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@ironcladlou, although tests passed, the following is in the operator's logs from the last (successful) test run: I am seeing the same on another PR from today. So we need to fix IAM policy to allow |
6 participants
Optimize the private zone discovery algorithm to replace the O(n) AWS API calls
with a single O(1) call to find the zone by its tag.
Needs some more testing. Wildcard DNS e2e is still blocked on a couple other things.
/cc @openshift/sig-network-edge @smarterclayton @wking @csrwng